Migrate from Travis to GitHub Actions #63
Conversation
| - curl -sL https://sentry.io/get-cli/ | bash | ||
| - export SENTRY_ORG=datamade | ||
| export SENTRY_PROJECT=ocd-scrapers | ||
| - VERSION=$(sentry-cli releases propose-version) | ||
| - sentry-cli releases new $VERSION | ||
| - sentry-cli releases set-commits $VERSION --commit opencivicdata/scrapers-us-municipal@`git rev-parse HEAD` | ||
| - sentry-cli releases finalize $VERSION |
There was a problem hiding this comment.
This has been failing for a while, i.e., has no effect. I decided not to replicate it in the GitHub Action.
| python-version: '3.5' | ||
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install --upgrade pip setuptools |
There was a problem hiding this comment.
Upgrading setuptools resolved the build error we've been seeing in Travis. Reference: django-haystack/django-haystack#1571 (comment)
| @@ -1,5 +1,6 @@ | |||
| django>=2.2,<2.3 | |||
| opencivicdata>=3.1.0 | |||
| # Better handling for loading divisions from specified CSV | |||
| https://github.com/opencivicdata/python-opencivicdata/archive/master.zip | |||
There was a problem hiding this comment.
do we want to peg this to a specific version, or have it float like this?
There was a problem hiding this comment.
Great question. I opened #64 and once I finish up datamade/how-to#210, let us pin!
| runs-on: ubuntu-18.04 | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Set up Python 3.5 |
There was a problem hiding this comment.
do we want to bump our python version 3.5 is now EOL. This is probably a separate issue.
There was a problem hiding this comment.
Another a great question. Opened #65.
There was a problem hiding this comment.
(My answer is not yet because the OCD scrapers on the server are still using Python 3.5.)
Description
This PR migrates from Travis to GitHub Actions and resolves a new build error that began plaguing us earlier this month. It also updates the deployment documentation to conform to the pattern of production deployments from the
deploybranch. (N.b., I have updated the automated build config in Docker Hub to build the production tag from thedeploybranch, too.) Finally, it installsopencivicdatafrom themasterbranch to capture recent changes that have not yet been rolled into a release.