Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed challenge #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoyCarlos
Copy link

Overview

Complete DataMade code challenge.

  • Had to add npm as an installed package in Dockerfile to fix npm: command not found error.
  • Added implementation of usaddress parser to API in views.py.
  • Added id fields to elements in index.html to wire them up to backend through index.js.
  • Completed 3 unit tests.
    • 1 unit test for valid address
    • 1 unit test for invalid address - repeat label (e.g. 1010 10th Street, Modesto 95354 1010 10th street)
    • 1 unit test for invalid address - empty address field

Demo

Screenshot 2024-07-14 at 9 38 59 PM

Screenshot 2024-07-14 at 9 39 23 PM

Screenshot 2024-07-14 at 9 35 35 PM

Notes

On some machines rather than using docker-compose you may need to use docker compose.

Testing Instructions

To run tests:
docker-compose -f docker-compose.yml -f tests/docker-compose.yml run --rm app
or as mentioned above:
docker compose -f docker-compose.yml -f tests/docker-compose.yml run --rm app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant