Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Jobs Verticle: Move Functionality to Database Service #158

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DivyaSreeMunagavalasa
Copy link
Contributor

@DivyaSreeMunagavalasa DivyaSreeMunagavalasa commented Jul 8, 2024

  • This PR includes code refactoring for the jobs verticle. Since the job service contains only one method, the entire jobs verticle package has been completely removed, and its functionality has been moved into the database service verticle.

@ThorodanBrom
Copy link
Collaborator

  • remove the jobs verticle block from the example config
  • @gopal-mahajan please review this PR

@jenkins-datakaveri
Copy link

Build finished.

1 similar comment
@jenkins-datakaveri
Copy link

Build finished.

Copy link
Collaborator

@gopal-mahajan gopal-mahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the comment

@jenkins-datakaveri
Copy link

Build finished.

1 similar comment
@jenkins-datakaveri
Copy link

Build finished.

Copy link
Collaborator

@gopal-mahajan gopal-mahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jenkins-datakaveri
Copy link

Build finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants