refactor: refactoring graphical by partial method

databendlabs · Sep 29, 2024 · 5b5b81c · 5b5b81c
1 parent 604e270
commit 5b5b81c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/query/ast/src/parser/statement.rs b/src/query/ast/src/parser/statement.rs
@@ -2200,7 +2200,6 @@ pub fn statement_body(i: Input) -> IResult<Statement> {
             #map(query, |query| Statement::Query(Box::new(query)))
             | #explain : "`EXPLAIN [PIPELINE | GRAPH] <statement>`"
             | #explain_analyze : "`EXPLAIN ANALYZE <statement>`"
-            | #explain_analyze_graphical : "`EXPLAIN ANALYZE GRAPHICAL <statement>`"
             | #show_settings : "`SHOW SETTINGS [<show_limit>]`"
             | #show_variables : "`SHOW VARIABLES [<show_limit>]`"
             | #show_stages : "`SHOW STAGES`"

diff --git a/src/query/ast/src/parser/token.rs b/src/query/ast/src/parser/token.rs
@@ -584,8 +584,6 @@ pub enum TokenKind {
     EXISTS,
     #[token("EXPLAIN", ignore(ascii_case))]
     EXPLAIN,
-    #[token("GRAPHICAL", ignore(ascii_case))]
-    GRAPHICAL,
     #[token("EXPIRE", ignore(ascii_case))]
     EXPIRE,
     #[token("EXTRACT", ignore(ascii_case))]

diff --git a/src/query/service/src/interpreters/interpreter_explain.rs b/src/query/service/src/interpreters/interpreter_explain.rs
@@ -448,7 +448,7 @@ impl ExplainInterpreter {
         let result = if self.partial {
             format_partial_tree(&plan, metadata, &query_profiles)?.format_pretty()?
         } else {
-            plan.format(metadata.clone(), query_profiles)?
+            plan.format(metadata.clone(), query_profiles.clone())?
                 .format_pretty()?
         };
         let line_split_result: Vec<&str> = result.lines().collect();

diff --git a/src/query/service/src/interpreters/interpreter_factory.rs b/src/query/service/src/interpreters/interpreter_factory.rs
@@ -123,20 +123,23 @@ impl InterpreterFactory {
                 kind.clone(),
                 config.clone(),
                 false,
+                false,
             )?)),
             Plan::ExplainAst { formatted_string } => Ok(Arc::new(ExplainInterpreter::try_create(
                 ctx,
                 plan.clone(),
                 ExplainKind::Ast(formatted_string.clone()),
                 ExplainConfig::default(),
                 false,
+                false,
             )?)),
             Plan::ExplainSyntax { formatted_sql } => Ok(Arc::new(ExplainInterpreter::try_create(
                 ctx,
                 plan.clone(),
                 ExplainKind::Syntax(formatted_sql.clone()),
                 ExplainConfig::default(),
                 false,
+                false,
             )?)),
             Plan::ExplainAnalyze { graphical, partial, plan } => Ok(Arc::new(ExplainInterpreter::try_create(
                 ctx,