Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to -> Change to in fix_data.yaml #178

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Rename to -> Change to in fix_data.yaml #178

merged 1 commit into from
Oct 4, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Oct 4, 2024

Rename to -> Change to

"rename" can be confused with a "rename" refactor that would change the definition as well.

`Rename to` -> `Change to`

"rename" can be confused with a "rename" refactor that would change the definition as well
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test that this works as intended locally.

@sigurdm
Copy link
Contributor Author

sigurdm commented Oct 4, 2024

Seems to work with a dependency_override:
image

@sigurdm sigurdm merged commit efe8ce3 into main Oct 4, 2024
7 checks passed
@sigurdm sigurdm deleted the sigurdm-patch-1 branch October 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants