Use the latest language version if we can't find a package. #1573
+47
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can find, read, and merge them. It handles `include` inside the file. It works using an abstraction over the file system so that (in theory at least), this code could be harvested and made reusable by other tools that need to work with analysis_options.yaml files but don't want to work directly with files on disk. It also includes an implementation of that abstraction using dart:io. Right now, this is all just private inside dart_style, but is organized so that it would be easy to pull out into a separate package later if we want.
It was getting pretty huge. I didn't want to stuff more tests in there for CLI integration of analysis_options, so splitting it up into smaller files first. There are no meaningful changes here, just moving code around.
When formatting from the CLI using files or stdin with a --stdin-name option, looks in the surrounding directories for an analysis_options.yaml file. If found and the file specifies a formatter page width, uses that. Handles includes and merging as well. Doesn't handle "package:" includes yet.
In the new tall-style behavior where we look for a surrounding package config to infer the language version of each file, we have to decide what to do when that look-up process fails (either because there is no package config, or it's malformed). Initially, I had it error out on that file. That's consistent with the library API where the formatter *requires* a language version before it will do anything. But it's not consistent with the language spec and our other tools. For them, if there is no valid surrounding package config, the file should be treated as the latest language version. This PR does that. It also fixes the catastrophic UX that the current code has which is that when a file can't have its language version inferred... it is silently skipped without telling the user anything. Oops. Now it just formats the file as expected.
kallentu
approved these changes
Oct 4, 2024
natebosch
approved these changes
Oct 4, 2024
# Conflicts: # lib/src/analysis_options/analysis_options_file.dart # lib/src/analysis_options/file_system.dart # lib/src/analysis_options/io_file_system.dart # lib/src/config_cache.dart # lib/src/io.dart # lib/src/testing/test_file_system.dart # test/analysis_options/analysis_options_file_test.dart # test/cli/language_version_test.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new tall-style behavior where we look for a surrounding package config to infer the language version of each file, we have to decide what to do when that look-up process fails (either because there is no package config, or it's malformed).
Initially, I had it error out on that file. That's consistent with the library API where the formatter requires a language version before it will do anything.
But it's not consistent with the language spec and our other tools. For them, if there is no valid surrounding package config, the file should be treated as the latest language version.
This PR does that.
It also fixes the catastrophic UX that the current code has which is that when a file can't have its language version inferred... it is silently skipped without telling the user anything. Oops. Now it just formats the file as expected.