Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2838. Variable named _ does not bind anything #2840

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It does look like we should expect one more error, or did I miss something?

Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Updated. PTAL.

@sgrekhov sgrekhov requested a review from eernstg August 29, 2024 11:24
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 4f52639 into dart-lang:master Aug 29, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 30, 2024
2024-08-29 [email protected] dart-lang/co19#2559. Add tests for some corner cases (dart-lang/co19#2836)
2024-08-29 [email protected] Fixes dart-lang/co19#2838. Variable named `_` does not bind anything (dart-lang/co19#2840)
2024-08-29 [email protected] dart-lang/co19#2559. Add scoping tests (dart-lang/co19#2835)
2024-08-29 [email protected] dart-lang/co19#2559. Fix extension types syntax (dart-lang/co19#2837)
2024-08-27 [email protected] dart-lang/co19#2559. Add extension types tests (dart-lang/co19#2831)
2024-08-26 [email protected] dart-lang/co19#2559. Add metadata tests (dart-lang/co19#2832)
2024-08-23 [email protected] dart-lang/co19#2559. Add more constructor augmentation tests around formal parameters (dart-lang/co19#2830)

Change-Id: I55ef74d7a2c34edbfbbfd91570b7efb250d0d40d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382884
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants