Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings when calling deprecated method #596

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

AdrienVannson
Copy link
Contributor

@AdrienVannson AdrienVannson commented Aug 14, 2024

Summary

Fix #595

This pool-request adds a warning when a deprecated method is called.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Collaborator

@Gobot1234 Gobot1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@Gobot1234 Gobot1234 merged commit 4e9a17c into danielgtaylor:master Aug 14, 2024
19 checks passed
Gobot1234 added a commit to JitPackJoyride/python-betterproto that referenced this pull request Aug 14, 2024
Gobot1234 added a commit that referenced this pull request Aug 14, 2024
* Bump version to 2.0.0b7

* chore: changes to changelog from PR comments

* chore: grammar fix

* Add entry for #596

* Apply suggestions from code review

---------

Co-authored-by: James Hilton-Balfe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated field not taken into account on methods
2 participants