Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make non-existent value states readable. #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make non-existent value states readable. #12

wants to merge 1 commit into from

Conversation

jmduke
Copy link

@jmduke jmduke commented May 20, 2014

See #10.

So I realize in my dumb hindsight that the issue isn't the regional values themselves, it's the interaction between fillColor and color as the individual regions are styled: basically white on white. My proposed solution is to give a default outline of light grey, so states can always be seen:

screen shot 2014-05-19 at 9 36 14 pm

I think it also makes sense that borderColor could be a configurable value (via url params), and could include that as a separate PR.

Since this is a bit more design-y than my prior hopes of it being a simple configuration issue, I understand if you have some reservations! Lemme know what ya think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant