Fix belongs to relation when parent is changed using parent id #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #432 +/- ##
============================================
+ Coverage 91.52% 91.58% +0.06%
- Complexity 1760 1765 +5
============================================
Files 112 112
Lines 4482 4504 +22
============================================
+ Hits 4102 4125 +23
+ Misses 380 379 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Fix #346
Fixed expected behavior:
If we change parent ID in a BelongsTo relation and store the child entity, the parent entity will be changed in the relation with the new one.
Before it was like this: the nullable BelongsTo relation can't be finished if the parent had loaded state.