Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uninitialized collections #431

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

roxblnfk
Copy link
Member

What was changed

Ignore uninitialized collections in HasMany and ManyToMany relations.
Unsetting of collection property means unlinking children.

Fix #339

… Unsetting of collection property means unlinking children.
@roxblnfk roxblnfk added the type:feature New feature. label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #431 (d3c37c8) into 2.x (04693aa) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #431      +/-   ##
============================================
+ Coverage     91.58%   91.60%   +0.02%     
- Complexity     1765     1766       +1     
============================================
  Files           112      112              
  Lines          4504     4505       +1     
============================================
+ Hits           4125     4127       +2     
+ Misses          379      378       -1     
Files Changed Coverage Δ
src/Mapper/Proxy/ProxyEntityFactory.php 94.59% <100.00%> (+1.26%) ⬆️
src/Relation/HasMany.php 96.52% <100.00%> (+0.06%) ⬆️

@roxblnfk roxblnfk marked this pull request as ready for review July 26, 2023 18:44
@roxblnfk roxblnfk requested a review from msmakouz August 1, 2023 16:28
@roxblnfk roxblnfk merged commit a3c072f into 2.x Aug 1, 2023
29 checks passed
@roxblnfk roxblnfk deleted the feature/nullable-collections branch August 1, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature.
Projects
None yet
1 participant