Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving relations hydration in ClosureHydrator #429

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Jul 24, 2023

What was changed

  1. Searching for a relation in the heap, instead of assigning a reference.
  2. Assigning a Reference instead of loading a relation from db when the relation type is mixed in the entity.

@msmakouz msmakouz requested a review from roxblnfk July 24, 2023 11:05
@msmakouz msmakouz self-assigned this Jul 24, 2023
@msmakouz msmakouz changed the title [tests] Adding test case for issue **#425** [tests] Adding test case for issue #425 Jul 24, 2023
@msmakouz msmakouz linked an issue Jul 24, 2023 that may be closed by this pull request
1 task
@msmakouz msmakouz marked this pull request as draft July 24, 2023 11:06
@msmakouz msmakouz changed the title [tests] Adding test case for issue #425 Improving relations hydration in **ClosureHydrator** Aug 3, 2023
@msmakouz msmakouz changed the title Improving relations hydration in **ClosureHydrator** Improving relations hydration in ClosureHydrator Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #429 (d5c485e) into 2.x (8b85b83) will increase coverage by 0.22%.
Report is 10 commits behind head on 2.x.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##                2.x     #429      +/-   ##
============================================
+ Coverage     91.38%   91.60%   +0.22%     
- Complexity     1760     1766       +6     
============================================
  Files           112      112              
  Lines          4480     4505      +25     
============================================
+ Hits           4094     4127      +33     
+ Misses          386      378       -8     
Files Changed Coverage Δ
src/Mapper/Proxy/Hydrator/ClosureHydrator.php 90.62% <80.00%> (+0.30%) ⬆️
src/Mapper/Proxy/ProxyEntityFactory.php 94.59% <100.00%> (+0.07%) ⬆️

... and 6 files with indirect coverage changes

@msmakouz msmakouz marked this pull request as ready for review August 3, 2023 14:00
@roxblnfk roxblnfk added type:feature New feature. and removed type:bug Bug labels Aug 3, 2023
@roxblnfk roxblnfk added this to the 2.4.x milestone Aug 3, 2023
@roxblnfk roxblnfk merged commit c201f0a into cycle:2.x Aug 4, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature. type:test Test
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants