Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] ManyToMany uncasts wrong fields #428

Merged
merged 2 commits into from
Jul 26, 2023
Merged

[Test] ManyToMany uncasts wrong fields #428

merged 2 commits into from
Jul 26, 2023

Conversation

roxblnfk
Copy link
Member

Test case for #427

@roxblnfk roxblnfk linked an issue Jul 24, 2023 that may be closed by this pull request
1 task
@roxblnfk roxblnfk changed the title ManyToMany uncasts wrong fields [Test] ManyToMany uncasts wrong fields Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #428 (f0b7197) into 2.x (8b85b83) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x     #428      +/-   ##
============================================
+ Coverage     91.38%   91.40%   +0.02%     
  Complexity     1760     1760              
============================================
  Files           112      112              
  Lines          4480     4480              
============================================
+ Hits           4094     4095       +1     
+ Misses          386      385       -1     
Files Changed Coverage Δ
src/Relation/ManyToMany.php 95.94% <100.00%> (ø)

... and 1 file with indirect coverage changes

@roxblnfk roxblnfk marked this pull request as ready for review July 26, 2023 15:01
@roxblnfk roxblnfk merged commit d53f328 into 2.x Jul 26, 2023
29 checks passed
@roxblnfk roxblnfk deleted the case427 branch July 26, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 ManyToMany id typecast gets wrong id
1 participant