Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading for Embedded entities when parent is null #423

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Fix loading for Embedded entities when parent is null #423

merged 3 commits into from
Jul 20, 2023

Conversation

gam6itko
Copy link
Contributor

@gam6itko gam6itko commented Jul 6, 2023

Test case for #422

@roxblnfk roxblnfk added the type:bug Bug label Jul 6, 2023
@roxblnfk roxblnfk linked an issue Jul 6, 2023 that may be closed by this pull request
🐛 load null relation with Embeddable #422
Closed
1 task
@roxblnfk roxblnfk added the type:test Test label Jul 6, 2023
@msmakouz msmakouz removed the type:test Test label Jul 20, 2023
@msmakouz msmakouz self-assigned this Jul 20, 2023
@msmakouz msmakouz requested a review from roxblnfk July 20, 2023 13:38
@msmakouz msmakouz changed the title [tests] Issue422 test case Fixing Embedded in nullable relations Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #423 (62ba232) into 2.x (c7edd6b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 62ba232 differs from pull request most recent head 7e9100e. Consider uploading reports for the commit 7e9100e to get more accurate results

@@             Coverage Diff              @@
##                2.x     #423      +/-   ##
============================================
- Coverage     91.42%   91.35%   -0.07%     
- Complexity     1754     1758       +4     
============================================
  Files           112      112              
  Lines          4464     4475      +11     
============================================
+ Hits           4081     4088       +7     
- Misses          383      387       +4
Impacted Files Coverage Δ
src/Parser/AbstractNode.php 92.74% <100.00%> (+0.70%) ⬆️

... and 3 files with indirect coverage changes

@roxblnfk roxblnfk changed the title Fixing Embedded in nullable relations Fix loading for Embedded entities when parent is null Jul 20, 2023
@roxblnfk roxblnfk merged commit 0530da3 into cycle:2.x Jul 20, 2023
27 checks passed
@gam6itko gam6itko deleted the embed_null_issue branch July 24, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk approved these changes

Assignees

@msmakouz msmakouz

Labels
type:bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 load null relation with Embeddable
3 participants
@gam6itko @roxblnfk @msmakouz