Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generated fields #31

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Add support for generated fields #31

merged 4 commits into from
Feb 8, 2024

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Feb 7, 2024

What was changed

Added support for GENERATED_FIELDS in the schema, which will be in the next version of Cycle ORM

Checklist

@roxblnfk roxblnfk mentioned this pull request Feb 8, 2024
7 tasks
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (891fd97) 82.21% compared to head (2858f4f) 82.93%.

Files Patch % Lines
src/Schema/RegistryModifier.php 91.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                1.x      #31      +/-   ##
============================================
+ Coverage     82.21%   82.93%   +0.72%     
  Complexity      154      154              
============================================
  Files            20       20              
  Lines           433      463      +30     
============================================
+ Hits            356      384      +28     
- Misses           77       79       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit fd6de37 into 1.x Feb 8, 2024
41 of 42 checks passed
@roxblnfk roxblnfk deleted the feature/generated-fields branch February 8, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement.
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

2 participants