issue-745: Set timeoutSeconds to 50sec #746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymmt2005
requested changes
Oct 4, 2024
Comment on lines
-244
to
246
| err = ss.DBOps[candidate].WaitForGTID(ctx, gtid, failOverTimeoutSeconds) | ||
| err = ss.DBOps[candidate].WaitForGTID(ctx, gtid, timeoutSeconds) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I think we can loop this if err is dbop.ErrTimeout.
https://github.com/cybozu-go/moco/blob/main/pkg/dbop/replication.go#L69
Comment on lines
-166
to
168
| err = ss.DBOps[ss.Candidate].WaitForGTID(ctx, pst.GlobalVariables.ExecutedGTID, switchOverTimeoutSeconds) | ||
| err = ss.DBOps[ss.Candidate].WaitForGTID(ctx, pst.GlobalVariables.ExecutedGTID, timeoutSeconds) | ||
| if err != nil { | ||
| return err | ||
| } |
ymmt2005
reviewed
Oct 4, 2024
Comment on lines
+243
to
246
| err = ss.DBOps[candidate].WaitForGTID(ctx, gtid, timeoutSeconds) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Suggested change
| err = ss.DBOps[candidate].WaitForGTID(ctx, gtid, timeoutSeconds) | |
| if err != nil { | |
| return err | |
| } | |
| REDO: | |
| err = ss.DBOps[candidate].WaitForGTID(ctx, gtid, timeoutSeconds) | |
| switch err { | |
| case dbop.ErrTimeout: | |
| goto REDO | |
| case nil: | |
| // ok | |
| default: | |
| return err | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#745