Skip to content

Commit

Permalink
Use different parameters name for auth and config group overrides
Browse files Browse the repository at this point in the history
Signed-off-by: Sergen Yalçın <[email protected]>
  • Loading branch information
sergenyalcin committed Sep 27, 2024
1 parent 7be17a7 commit f73221f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,12 @@ export XPKG_REG_ORGS_NO_PROMOTE := $(XPKG_REG_ORGS_NO_PROMOTE)
export XPKG_DIR := $(XPKG_DIR)
export XPKG_IGNORE := $(XPKG_IGNORE)

CONFIG_CRD_GROUP = $(PROVIDER_NAME)
PROVIDER_AUTH_GROUP = $(PROVIDER_NAME)

export CONFIG_CRD_GROUP := $(CONFIG_CRD_GROUP)
export PROVIDER_AUTH_GROUP := $(PROVIDER_AUTH_GROUP)

-include build/makelib/xpkg.mk

# Targets
Expand Down
4 changes: 2 additions & 2 deletions cluster/images/provider-azure/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ batch-process: $(UP)
--auth-ext $(XPKG_DIR)/auth.yaml \
--crd-root $(XPKG_DIR)/crds \
--ignore $(XPKG_IGNORE) \
--crd-group-override monolith=* --crd-group-override config=$(PROVIDER_NAME) \
--crd-group-override monolith=* --crd-group-override config=$(CONFIG_CRD_GROUP) \
--package-metadata-template $(XPKG_DIR)/crossplane.yaml.tmpl \
--template-var XpkgRegOrg=$(XPKG_REG_ORGS) --template-var DepConstraint="$(DEP_CONSTRAINT)" --template-var ProviderName=$(PROVIDER_NAME) \
--template-var XpkgRegOrg=$(XPKG_REG_ORGS) --template-var DepConstraint="$(DEP_CONSTRAINT)" --template-var ProviderName=$(PROVIDER_NAME) --template-var ProviderAuthGroup=$(PROVIDER_AUTH_GROUP) \
--concurrency $(CONCURRENCY) \
--push-retry 10 || $(FAIL)
@$(OK) Done processing smaller provider packages for: "$(SUBPACKAGES)"
Expand Down
2 changes: 1 addition & 1 deletion package/crossplane.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ metadata:
If you encounter an issue please reach out on [email protected] email
address. This is a subpackage for the {{ .Service }} API group.
friendly-name.meta.crossplane.io: Provider Azure ({{ .Service }})
auth.upbound.io/group: {{ .ProviderName }}.upbound.io
auth.upbound.io/group: {{ .ProviderAuthGroup }}.upbound.io
spec:
{{ if ne .Service "monolith" }}
crossplane:
Expand Down

0 comments on commit f73221f

Please sign in to comment.