Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update go to 1.22.5 #52

Merged
merged 12 commits into from
Jul 20, 2024
Merged

chore(build): update go to 1.22.5 #52

merged 12 commits into from
Jul 20, 2024

Conversation

displague
Copy link
Collaborator

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@displague displague changed the title chore(build): update go to 1.22 chore(build): update go to 1.22.5 Jul 14, 2024
Signed-off-by: Marques Johansson <[email protected]>
@displague
Copy link
Collaborator Author

displague commented Jul 19, 2024

As a reminder to future myself:

angryjet: error: error loading packages using pattern ./...: /home/marques/src/provider-jet-equinix/apis/ecx/v1alpha1/zz_generated.managed.go:23:11: undefined: L2Connection

During larger upgrades of the provider from newer template patterns, I've encountered problems like the above one.

I've forgotten and had to relearn this on numerous occassions:

make distclean clean
find internal/ apis/ -name zz_\* -type f  | xargs rm 
make generate

Without doing this, traces of older .go locations and Terraform provider download/processing are not completely cleared.

github.com/crossplane/crossplane-runtime v1.16.0
github.com/crossplane/crossplane-tools v0.0.0-20240516011917-bfb5045f0903
github.com/crossplane/upjet v1.4.0
github.com/equinix/terraform-provider-equinix v1.39.1-0.20240719163601-ff3f466a27ce
Copy link
Collaborator Author

@displague displague Jul 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on equinix/terraform-provider-equinix#735 (the branch, not a merge)

@displague displague marked this pull request as ready for review July 20, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant