NCC in CCM is not correctly computed

[victornoel]

While investigating #447, I noticed a potential error in the xsl file, but I'm not 100% sure it is an error or not because I'm not very good with xsl.

Actually this error has no impact to solve #447 because the number it find is the correct one even though the calculation is wrong. There was another error somewhere else.

Basically, NCC is meant to be the number of connected components (of the graph where methods are the nodes and are connected according to some criteria). See for example https://www.geeksforgeeks.org/connected-components-in-an-undirected-graph/ to understand how to count them. It is not the number of nodes.

NCC is the xsl is defined like this, and it seems to count the number of nodes:

<xsl:variable name="ncc" select="count(distinct-values($edges/edge/method/text()))"/>

Furthermore it counts them incorrectly because the name of the method is used and some methods have the same name in some of the test classes... I will create another issue for that problem because it pertains to other metrics I think. actually it doesn't seem to be the case.

[0crat]

@paulodamaso/z please, pay attention to this issue

[paulodamaso]

@victornoel Could you please fix the title? It is just related to NCC right?

[victornoel]

@paulodamaso yes sorry, it was in not is :)

[paulodamaso]

@victornoel Thank you!

[paulodamaso]

@0crat in

[0crat]

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

[0crat]

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

[0crat]

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

[0crat]

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

[0crat]

@0crat in (here)

@paulodamaso Election failed: performer was not elected (see footprint for details)

[0crat]

The job #449 assigned to @HDouss/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[HDouss]

@victornoel it is actually calculating the number of nodes having an edge. And yes, it is completely erroneous.

[HDouss]

@0crat refuse will have to wait too much for #437 and its puzzles..

[0crat]

@0crat refuse will have to wait too much for #437 and its puzzles.. (here)

@HDouss The user @HDouss/z resigned from #449, please stop working. Reason for job resignation: Order was cancelled

[0crat]

@0crat refuse will have to wait too much for #437 and its puzzles.. (here)

@HDouss Job refused in 0 hours - no penalty, see §6

[0crat]

The job #449 assigned to @dfrau32/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[0crat]

@dfrau32/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[0crat]

The user @dfrau32/z resigned from #449, please stop working. Reason for job resignation: It is older than 10 days, see §8

[0crat]

The job #449 assigned to @vzurauskas/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[vzurauskas]

@paulodamaso If I understand correctly, the Graph interface was created in order to do calculations like the one required here because graphs are better handled in Java than XSL, correct? If so, would it make sense to rewrite CCM metric in Java instead of fixing this calculation in the XSL?

[vzurauskas]

@0crat wait for clarification.

[paulodamaso]

@vzurauskas Yes, it makes sense, let's use java to make these calculations that need graphs

[vzurauskas]

@victornoel #477 was merged and todos created, can this be closed now?

[victornoel]

@vzurauskas thx!

[0crat]

@vzurauskas/z resigned from #449, since the job is not in scope anymore

[vzurauskas]

@paulodamaso Zerocrat resigned me, but should have asked for quality review and paid me after that.

[paulodamaso]

@0crat status

[0crat]

@0crat status (here)

@paulodamaso This is what I know about this job in C7JGJ00DP, as in §32:

• The job #449 is not in scope
• Job footprint (restricted area)

[paulodamaso]

@0crat in

[vzurauskas]

@0crat status

[0crat]

@0crat status (here)

@vzurauskas This is what I know about this job in C7JGJ00DP, as in §32:

• The job #449 is not in scope
• Job footprint (restricted area)

[vzurauskas]

@paulodamaso The ticket is still stuck.

[vzurauskas]

@paulodamaso ping

[0pdd]

@victornoel 2 puzzles #481, #482 are still not solved.

[vzurauskas]

@paulodamaso ping

[paulodamaso]

@0crat quality good

[0crat]

@0crat quality good (here)

@paulodamaso There is no quality review for #449, no performer

[0pdd]

@victornoel 2 puzzles #511, #512 are still not solved.