Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCM calculation is wrong #447

Closed
vzurauskas opened this issue Apr 10, 2020 · 13 comments
Closed

CCM calculation is wrong #447

vzurauskas opened this issue Apr 10, 2020 · 13 comments

Comments

@vzurauskas
Copy link
Contributor

In metricstest-params there is a line OverloadMethods,CCM,0.6d. This means OverloadMethods class from the test samples has CCM of 0.6.

CCM = NC/(NMP x NCC)

In OverloadMethods there are 4 methods, each accessing the same attribute. So:
NC = 6
NMP = 6
NCC = 1

Therefore CCM should be 1.0, not 0.6.

@0crat
Copy link
Collaborator

0crat commented Apr 10, 2020

@paulodamaso/z please, pay attention to this issue

@paulodamaso
Copy link
Collaborator

@0crat in

@0crat
Copy link
Collaborator

0crat commented Apr 15, 2020

The job #447 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@victornoel
Copy link
Contributor

@vzurauskas why does NCC equals 1 ? It is the number of connected components, there are 4 methods and they are all connected to another method, so it should be 4, no?

And thus, CCM should be 6/(6x4) = 0.25

@victornoel
Copy link
Contributor

@vzurauskas my bad, I better understand now, the number of connected component is the set of 4 methods that are connected together, so it is 1.

victornoel added a commit to victornoel/jpeek that referenced this issue Apr 16, 2020
Found with sort metricstest-params.csv | uniq -d
victornoel added a commit to victornoel/jpeek that referenced this issue Apr 16, 2020
victornoel added a commit to victornoel/jpeek that referenced this issue Apr 16, 2020
@victornoel victornoel mentioned this issue Apr 16, 2020
Merged
@victornoel
Copy link
Contributor

@0crat wait for #450 to be merged

@victornoel
Copy link
Contributor

@vzurauskas the problem is that the constructor is counted as one of the methods.

Furthermore I realised that the computation for NCC is incorrect (even though in this particular case it computes the correct result of 1). I opened #449 for that since it wasn't related to the bug you uncovered.

@0pdd
Copy link
Collaborator

0pdd commented Apr 17, 2020

@vzurauskas the puzzle #453 is still not solved.

@victornoel
Copy link
Contributor

@vzurauskas the PR has been merged and the work will continue in #453. Can you close this issue?

@vzurauskas
Copy link
Contributor Author

@victornoel Closing, thanks.

@0crat 0crat added qa and removed waiting labels Apr 20, 2020
@0crat
Copy link
Collaborator

0crat commented Apr 20, 2020

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@0crat quality good

@0pdd
Copy link
Collaborator

0pdd commented Apr 21, 2020

@vzurauskas the only puzzle #453 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants