For riders and dispatchers, show <order number>-<delivery_position> instead of <task.id> #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-8
approved these changes
Sep 9, 2024
| return tasks.reduce( | ||
| (label, task, idx) => { | ||
| return `${label}${idx !== 0 ? ',' : ''} #${task.id}`; | ||
| const taskIdentifier = task?.metadata?.order_number ? `${task.metadata.order_number}-${task?.metadata?.delivery_position}` : task.id |
There was a problem hiding this comment.
I see it a second time, maybe use a util function?
There was a problem hiding this comment.
where ? in TaskTitle component ?
Atala
force-pushed
the
show-task-order-number
branch
from
67c592f
to
57ee6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to coopcycle/coopcycle-web#4583
I think it can be merged safely without merging the related backend PR, but you will see more things if it is set!