Allow paying with Edenred #1825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsegura
force-pushed
the
edenred
branch
3 times, most recently
from
f39b534
to
977fd9d
Compare
vladimir-8
reviewed
Oct 8, 2024
vladimir-8
reviewed
Oct 8, 2024
| ) | ||
| } | ||
|
|
||
| function mapStateToProps(state) { |
There was a problem hiding this comment.
Maybe we should discuss it first, but for me, using useSelector and useDispatch makes code easier to understand, rather than scrolling back and forth to know what each prop means. See, for example: https://github.com/coopcycle/coopcycle-app/blob/645241035b8e9bd96eb481a3b483aee1f44f2280/src/navigation/account/RegisterConfirm.js
|
@alexsegura please check the tests before merging if some of them have a valid reason to fail. And I'll test again when we have a production build ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775