-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delivery form #1802
Delivery form #1802
Conversation
Pierre-LHOSTE
commented
May 28, 2024
•
edited
Loading
edited
- Add client list search
- Add business name field (optional)
- Move address field from 2nd page to first page (obligatory)
- Move who to contact field from 2nd page to first page (obligatory)
- Move phone number from 2nd page to first page (obligatory)
- Add package selection feature
- Package selection is obligatory or not based on store configuration
- Add weight field
- Weight is obligatory or not based on store configuration
- Add time slot selection feature
- Time slot automatically is default time slot
- Add time range selector
- Time range automatically prefill next possible time range
e3173b0
to
be67c5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two big problems to be solved :
- the address search does not work on android
console.error: VirtualizedLists should never be nested inside plain ScrollViews with the same orientation because it can break windowing and other functionality - use another VirtualizedList-backed container instead.
- "Rechercher un client" does not search in address book but in past deliveries addresses
tested OK :
- select timeslot
- add packages
`
dispatch(setLoading(false)); | ||
}) | ||
.catch(e => { | ||
dispatch(setLoading(false)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add an error log here
import { DatadogLogger } from '../Datadog'; DatadogLogger.error(e)
(actually i dont know what happen if we dont log here and dont raise, I guess it will crash somewhere else with a less understandable message)
@@ -249,7 +313,7 @@ export function init(store) { | |||
|
|||
Promise.all([ | |||
httpClient.get(`${store['@id']}/deliveries?order[dropoff.before]=desc`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may not work with multi-dropoff deliveries. maybe let's create an issue to remember this when you start working on this