Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize colors in a global file #1773

Merged
merged 9 commits into from
May 6, 2024
Merged

Centralize colors in a global file #1773

merged 9 commits into from
May 6, 2024

Conversation

Pierre-LHOSTE
Copy link
Contributor

@Pierre-LHOSTE Pierre-LHOSTE commented Apr 25, 2024 •
edited
Loading

#1765

This PR

  • Adds colors.io package to manipulate colors 285a0d0
  • Adds and utilizes color hook centralized in theme.js file 220e5bd cca8fef 39d4c21
  • Updates AskAddress.js page to use new colors ede58ea
  • Adds function to update the primaryColor to get better contrast depending on theme for accessibility 285a0d0
  • Uses primaryColor instead of random highlight color 08ec80d
  • Remove empty space between menu and restaurant list 5c6b946

@Pierre-LHOSTE Pierre-LHOSTE marked this pull request as ready for review May 2, 2024 09:42
@vladimir-8 vladimir-8 self-requested a review May 2, 2024 19:16
vladimir-8
vladimir-8 approved these changes May 2, 2024
View reviewed changes
src/styles/theme.js Outdated Show resolved Hide resolved
src/navigation/checkout/Search.js Outdated Show resolved Hide resolved
@Pierre-LHOSTE Pierre-LHOSTE merged commit 996e5a7 into master May 6, 2024
6 checks passed
@Pierre-LHOSTE Pierre-LHOSTE deleted the global-colors branch May 6, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimir-8 vladimir-8 vladimir-8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pierre-LHOSTE @vladimir-8