Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon and text color in header #1770

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Conversation

Pierre-LHOSTE
Copy link
Contributor

@Pierre-LHOSTE Pierre-LHOSTE commented Apr 23, 2024

This PR fixes the color of some elements that were white and are now invisible with the new header color in light mode #1741
It also fixes the fact that the delivery address text (below the header) can overflow

@Pierre-LHOSTE Pierre-LHOSTE changed the title Fix icon color in header Fix icon and text color in header Apr 23, 2024
@Pierre-LHOSTE Pierre-LHOSTE marked this pull request as ready for review April 23, 2024 13:46
Copy link
Contributor

@vladimir-8 vladimir-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please add screenshots next time. I understand that adding before and after states could be time consuming, so it would be great if you can add the after state at least. It helps a lot to understand what the pull requests is about

const headerButtons = nav => (
<View style={styles.buttonBar}>
<ButtonWithIcon
name="settings"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call it icon

@Pierre-LHOSTE Pierre-LHOSTE merged commit 145afb6 into master Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants