-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: add wasi-demo-app to the publish pipeline #733
Open
Mossaka
wants to merge
19
commits into
containerd:main
Choose a base branch
from
Mossaka:pub-wasi-demo-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
reviewed
Nov 21, 2024
Signed-off-by: jiaxiao zhou <[email protected]>
… workflow Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
…w and use ctr Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
…larity Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
pub-wasi-demo-app
branch
from
December 16, 2024 01:32
2580f50
to
285c30c
Compare
* Renamed relaese-wasi-demo-app.yml to release-wasi-demo-app.yml to fix a typo. * Corrected indentation for the dry_run input in the workflow file. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
* Replaced individual make commands with make load and make load/oci. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
* Added a sign.yml workflow to sign container images using cosign. * Added sbom.yml workflow to generate, sign, and attach SBOMs to OCI images. * Added new workflows (sign-wasi-demo-app, sbom-wasi-demo-app, etc.) into the release pipeline for all image types. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
* Updated sign.yml and sbom.yml to use image-digest instead of version. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
jsturtevant
reviewed
Dec 16, 2024
set -e | ||
IMG_REPOSITORY_NAME=$( echo ${{ github.repository }} | awk '{print tolower($0)}' ) | ||
echo IMG_REPOSITORY_NAME=${IMG_REPOSITORY_NAME} >> $GITHUB_ENV | ||
DIGEST=$(crane digest \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can accomplish the same thing with docker which is already installed. I would prefer not installing extra GitHub actions if not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release
You can release the image by running
Verify Signing:
Forked Run
You can view a sample run in my forked repo: https://github.com/Mossaka/runwasi/actions/runs/12346148057
and released images: https://github.com/Mossaka/runwasi/pkgs/container/runwasi%2Fwasi-demo-app
note that each release produces four tags:
sha256-21a41dba8c23d354309d4fdb0b7e7a1afa0eee98ec522d7c31e47d3a5c4b6b2f.sig
sha256-d517c179cfaee83d38c83f874df5991c87719f6a06873b08b4b1a4de6a97b98a.sbom
sha256-d517c179cfaee83d38c83f874df5991c87719f6a06873b08b4b1a4de6a97b98a.sig
0.3.0
They are the image, the signature of the image, the SBOM and the signature of the SBOM.