Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore 0.8.0 behavior of header values overriding earlier ones for the same key #163

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Restore 0.8.0 behavior of header values overriding earlier ones for the same key #163

merged 1 commit into from
Jul 22, 2024

Conversation

nafg
Copy link
Contributor

@nafg nafg commented Jul 17, 2024 •
edited
Loading

Fixes #161

@nafg
Copy link
Contributor Author

nafg commented Jul 17, 2024

I didn't add a test.

I try to preserve the header order and case while overwriting by case-insensitive key. To do this I involve a ListMap with lower-cased keys for the map entry key, while including the original key string in the map entry value.

@lihaoyi lihaoyi merged commit fa71753 into com-lihaoyi:master Jul 22, 2024
4 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Jul 22, 2024

Thanks @nafg ! No worries about the test, I'll add one

lihaoyi added a commit that referenced this pull request Jul 22, 2024
@lihaoyi
Add test for #163 (#164)
927132b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate content-type Headers, 0.9.0-RC1
2 participants
@nafg @lihaoyi