[WIP] Hello world Kotlin Jetpack Compose Example; Fixes:#3550 #3696
+151
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@himanshumahajan138 maybe try again on latest master see if it's fixed by the recent klib changes? |
|
Android artifacts are distributed as |
|
Thanks @0xnm ! @alexarchambault any chance we could add |
@0xnm Hats off to you and your Experience sir! WOW ! i was trying to solve why this was not working checked alot of files and out folders but i think this needs a pause till we get .aar support for android specific dependency @lihaoyi what u say sir... |
|
Adding them by default in coursier could be an option too… 🤔 |
|
Is there any manual process for now to add the support for android specific dependencies specifically jetpack compose |
|
@himanshumahajan138 Cherry-picking the commits of #3703 and adding the snippet of #3696 (comment) to your android modules ought to work |
|
actually what i think could be better is first let your #3703 merged to master and then do the further changes to this code to resolve conflicts |
|
@alexarchambault sounds good! I'm happy as long as we have some way to configure it in Mill, whether it should go upstream into Coursier is up to you |
|
@himanshumahajan138 I've merged the other PR, you can try using it |
|
Please Check Latest Commit... i think we need to have a particular case for please pardon me if i did something in wrong way but i think its following the solution suggested in this conversation |
|
See this example for the Please share thoughts on this implementation if possible... |
|
@himanshumahajan138 The following patch brings the diff --git a/scalalib/src/mill/scalalib/JavaModule.scala b/scalalib/src/mill/scalalib/JavaModule.scala
index f72bc67c74..4d92101bcb 100644
--- a/scalalib/src/mill/scalalib/JavaModule.scala
+++ b/scalalib/src/mill/scalalib/JavaModule.scala
@@ -545,7 +545,10 @@ trait JavaModule
* Resolved dependencies based on [[transitiveIvyDeps]] and [[transitiveCompileIvyDeps]].
*/
def resolvedIvyDeps: T[Agg[PathRef]] = Task {
- defaultResolver().resolveDeps(transitiveCompileIvyDeps() ++ transitiveIvyDeps())
+ defaultResolver().resolveDeps(
+ transitiveCompileIvyDeps() ++ transitiveIvyDeps(),
+ artifactTypes = Some(artifactTypes())
+ )
}
/**(not sure why, I had to remove Then it seems some missing classes are in |
|
After a very Deep study about
Now what could be the solution then
in short: we need support for @lihaoyi @alexarchambault @0xnm please check out if we can achieve this thing |
|
lgtm |
|
for a proof i want to share the |
sorry, i mistakenly mentioned your profile |
Strictly speaking it is not needed to make things work. It is just a handy descriptor of the versions of the artifacts that will be used, but nothing prevents to specify versions individually, without BOM. I believe you need to wait for the #3719 to be merged, because you are interested in compile classpath, not in the runtime one. |
yaa i do agree, for sake of simplicity adding BOM will remove the individual versions addition, it will automatically fetch the latest compatible dependencies versions for jetpack compose |
lihaoyi
pushed a commit
that referenced
this pull request
Oct 11, 2024
Follow-up of #3703 that added `JavaModule.artifactTypes`. `JavaModule` performs two dependency resolutions: one for `compileClasspath`, the other for `runClasspath`. #3703 used `artifactTypes` in the `runClasspath` one, but not in the `compileClasspath` one. The PR here fixes that, and adds unit tests for both paths. This addresses the issues found around #3696 (comment).
|
Got the aar files in the why its happening i have checked that we have proper classpath but still why this is happening
|
|
Now, since you have it on the disk, you need to process it first to be able to feed included Also please convert this PR to Draft until you have completely working solution to avoid notifications been sent for every action made here. |
yaa i forgot sorry for that |
|
@0xnm Sir Actually i need a little bit more guide about
Now i am not sure about the situation like we know that And also, if we are using any of the above method then we should do this step before adding them into the |
|
After Performing conversion of Anyone who knows why i am still getting unresolved error even after adding required jar files. compileClasspath.json Error: #3696 (comment) |
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request:
[Request for Help] Unresolved Reference Errors in Android Project with Jetpack Compose
Issue:#3550
Description:
I am facing unresolved reference errors when compiling my Android project using Kotlin and Jetpack Compose. Below is a summary of the issue and what I have tried so far. I need assistance to resolve this.
My perspective is that it is unable to connect with the kotlin compiler and also there is no support for the
BOMfor jetpack compose just like present in the gradle and this leads to dependency conflicts alsoError Messages:
Steps I Have Taken:
build.mill.Request:
I need help in identifying why the references for
activityandcomposeare unresolved, despite including the relevant dependencies inbuild.mill. Any guidance or fixes would be greatly appreciated.Sir @lihaoyi please review the code and guide me...