Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add event parameter ordering #26

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add event parameter ordering #26

wants to merge 2 commits into from

Conversation

abdulla-cb
Copy link

  • add rule about ordering event parameters

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 9, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

wilsoncusack
wilsoncusack reviewed Sep 9, 2024
View reviewed changes
README.md Outdated
@@ -91,6 +91,22 @@ NO:
event UpdatedOwner(address newOwner);
```

##### C. Order event parameters in chronological order.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "chronological" could be confusing 🤔 . Might make more sense to say like, "Events logging updated values should follow the convention: previous, new

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I agree I think it's confusing, I've just updated it - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsoncusack wilsoncusack Awaiting requested review from wilsoncusack

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdulla-cb @cb-heimdall @wilsoncusack