feat: [Pay] components
#1349
Open
feat: [Pay] components
#1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xAlec
commented
Oct 3, 2024
alessey
reviewed
Oct 3, 2024
src/pay/components/Pay.tsx
Outdated
| onStatus={onStatus} | ||
| productId={productId} | ||
| > | ||
| <div className={cn(className, 'flex w-full flex-col gap-2')}> |
alessey
reviewed
Oct 3, 2024
| 'noopener,noreferrer', | ||
| ); | ||
| return; | ||
| } |
There was a problem hiding this comment.
may be more straightforward to have separate callbacks for handleFundingFlow and handleViewReceipt and then call different callbacks in the button based on the status
There was a problem hiding this comment.
I'll refactor this as a fast follow once we have USDC magic spend
There was a problem hiding this comment.
we'll delete the funding-related code in a few weeks I believe
alessey
reviewed
Oct 3, 2024
src/pay/components/PayProvider.tsx
Outdated
| if ( | ||
| (error as Error).message?.includes('User denied connection request') | ||
| ) { | ||
| setErrorMessage(USER_REJECTED_ERROR); |
There was a problem hiding this comment.
shouldn't this also updateLifecycleStatus?
alessey
reviewed
Oct 3, 2024
| <div className={cn(text.label2, className)}> | ||
| <p className={cn(labelClassName, className)}>{label}</p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
pass className into all three seems like it could make some styling difficult
alessey
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
PayButton,Pay, andPayStatususeGetPayStatususeCommerceContractscallback to take anaddressas an argumentNotes to reviewers
How has it been tested?
playground PR next