Adjust status functionality for transaction component #1239
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| useEffect(() => { | ||
| if ( | ||
| transactionStatus === 'pending' && | ||
| lifeCycleStatus.statusName === 'transactionLegacyExecuted' |
There was a problem hiding this comment.
shouldn't lifeCycleStatus already have been set by the useEffect above that also checks transactionStatus pending?
There was a problem hiding this comment.
yes but transaction status doesn't actually change. it is pending until it reaches the success state so lifeCycleStatus wasn't getting reset to transactionPending after we change it to transactionLegacyExecuted
| @@ -76,6 +76,10 @@ export function TransactionProvider({ | |||
| ? TRANSACTION_TYPE_CALLS | |||
| : TRANSACTION_TYPE_CONTRACTS; | |||
|
|
|||
| const [prevStatusEmitted, setPrevStatusEmitted] = useState( | |||
There was a problem hiding this comment.
nit: can we use previousStatus, setPreviousStatus instead
There was a problem hiding this comment.
@abcrane123 this approach adds more complexity to our logic, and makes it harder to mantain later.
What we should do instead, is add a persistant value inside statusData that keep info regarding the pending part.
With @alessey we are actually exploring this way of thinking for Swap and make sure become the new standard #1237
Make sure to sync with @alessey and follow the same approach.
| if (prevStatusEmitted !== lifeCycleStatus.statusName) { | ||
| onStatus?.(lifeCycleStatus); | ||
| setPrevStatusEmitted(lifeCycleStatus.statusName); | ||
| } |
There was a problem hiding this comment.
are there any other use cases aside from subsequent transactions that we want to emit duplicate statuses for?
e.g. init?
I'd also add some comments here on why this is an edge case (multiple pending transactions)
There was a problem hiding this comment.
also nit but if we can make this something like
if (previousStatus !== currentStatus) {
// some comment here on edge case
}
``
What changed? Why?
transactionPending->transactionLegacyExecuted->transactionLegacyExecutedtransactionPending->transactionLegacyExecuted->transactionPending->transactionLegacyExecutedsuccessstatuses: the first one contained both transaction receipts, the second one contained only a single transaction receipt.Notes to reviewers
How has it been tested?