-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding publish step in ci #13
base: main
Are you sure you want to change the base?
Conversation
|
357d2d4
to
ff3856f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me, great to publish to PyPi - can you explain how the package versioning gets defined though? Not clear on that part, and want to make sure it's sensible.
If I am not wrong, it should be the same version as specified in |
If that is the case, I think we should change from 0.1.0 to 1.0.0 or 0.2.0 at least. We should define the dev workflow when making changes too, for example if I add something new do I need to manual increment a minor version? |
ff3856f
to
3d6a5c7
Compare
let's start with 1.0.0
It should be the standard, 1.0.+ for bug fix, 1.+.0 for new features and +.0.0 for breaking changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be the standard, 1.0.+ for bug fix, 1.+.0 for new features and +.0.0 for breaking changes
This feels like it should be a github action or pre-commit hook. Basically check every PR includes a version change, and include the criteria for each type. Can come as another PR, but do you agree? And how would you enforce this?
Now if I think about it, isn't that what a tag is for? Maybe picking the version via tag is a better option. Ideally consistency between |
3d6a5c7
to
5dc1b56
Compare
bc1e311
to
541610e
Compare
40a5a69
to
7e3d586
Compare
7e3d586
to
bb00428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I defer to @miguelvr for final approve here though
I have added a step to publish compass-sdk on pypi. This is a step similar to how we release cohere-python package.