-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove enterprise cloud support plan flag #3506
base: main
Are you sure you want to change the base?
Conversation
Bundle ReportChanges will decrease total bundle size by 508 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 508 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3506 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 804 -2
Lines 14369 14348 -21
Branches 4077 4068 -9
==========================================
- Hits 14216 14195 -21
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3506 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 804 -2
Lines 14369 14348 -21
Branches 4077 4068 -9
==========================================
- Hits 14216 14195 -21
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3506 +/- ##
==========================================
- Coverage 98.93% 98.93% -0.01%
==========================================
Files 806 804 -2
Lines 14369 14348 -21
Branches 4077 4068 -9
==========================================
- Hits 14216 14195 -21
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR aims to remove the enterprise cloud support plan flag, and subsequently the ability to "find" the enterprise plans when upgrading to a pro plan
Launch Darkly link: https://app.launchdarkly.com/projects/dashboard/flags/enterprise-cloud-plan-support/targeting?env=test&env=production&selected-env=production
Interestingly we default the flag state to true, but the flag is off and has been off since June 2022
Closes #2936
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.