sstable: add ComparePrev, SetSnapshotPinnedProperties to RawWriter #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @jbowens)
internal/compact/splitting.go line 209 at r1 (raw file):
// INVARIANT: nextUserKey must match the current frontier. func (s *OutputSplitter) ShouldSplitBefore( nextUserKey []byte, estimatedFileSize uint64, comparePrevFn func([]byte) int,
[nit] I think we should make this equalToPrevFn func([]byte) bool so we don't have to worry about which key is on which side of the comparison
jbowens
force-pushed
the
rawwriter-extensions
branch
from
12dc887
to
70ec7fc
Compare
jbowens
commented
Sep 27, 2024
There was a problem hiding this comment.
TFTR!
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @RaduBerinde)
internal/compact/splitting.go line 209 at r1 (raw file):
Previously, RaduBerinde wrote…
[nit] I think we should make this
equalToPrevFn func([]byte) boolso we don't have to worry about which key is on which side of the comparison
Good idea
Extend the RawWriter interface to support two additional methods required by compactions. The RawRowWriter.UnsafeLastPointUserKey method is adapted into ComparePrev so that it may be implemented by RawColumnWriter without materializing the previous key.
jbowens
force-pushed
the
rawwriter-extensions
branch
from
70ec7fc
to
abb03cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the RawWriter interface to support two additional methods required by compactions. The RawRowWriter.UnsafeLastPointUserKey method is adapted into ComparePrev so that it may be implemented by RawColumnWriter without materializing the previous key.