Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sstable: support columnar blocks in Layout.Describe #3960

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Sep 25, 2024

Adapt Layout.Describe to support describing sstables containing columnar blocks.

@jbowens jbowens requested a review from a team as a code owner September 25, 2024 01:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens force-pushed the layout-colblk branch 2 times, most recently from 65151a4 to e9b4f7c Compare September 25, 2024 20:41
@jbowens

This comment was marked as resolved.

Adapt Layout.Describe to support describing sstables containing columnar
blocks.
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @sumeerbhola)

@jbowens
Copy link
Collaborator Author

jbowens commented Sep 26, 2024

TFTR!

@jbowens jbowens merged commit 575f7a0 into cockroachdb:master Sep 26, 2024
11 of 12 checks passed
@jbowens jbowens deleted the layout-colblk branch September 26, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants