changefeedccl: move checkpoint creation code into separate package #137959
+308
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andyyang890
force-pushed
the
20241223-move-checkpoint-separate-package
branch
2 times, most recently
from
54422e8 to
2d11274
Compare
This patch moves the changefeed checkpoint creation code into a separate package to prevent a dependency cycle when the resolved span frontiers are moved into its own package in a later commit. Given the upcoming checkpoint improvement work, this is also a good opportunity to clean up the checkpoint creation API. Finally, a unit test covering checkpoint creation has been added. Release note: None
andyyang890
force-pushed
the
20241223-move-checkpoint-separate-package
branch
from
2d11274 to
c0e886c
Compare
andyyang890
requested review from
wenyihu6,
asg0451 and
a team
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the changefeed checkpoint creation code into a
separate package to prevent a dependency cycle when the resolved
span frontiers are moved into its own package in a later commit.
Given the upcoming checkpoint improvement work, this is also a
good opportunity to clean up the checkpoint creation API.
Finally, a unit test covering checkpoint creation has been added.
Epic: None
Release note: None