release-24.2: sql/types, sql/stats: fix SQLStringFullyQualified for arrays of UDTs #137954
+159
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #137448.
/cc @cockroachdb/release
Starting in v24.2 we added
SQLStringFullyQualified
, but it looks like it didn't work for arrays of user-defined types. This is only used in a few places, including the output ofSHOW STATISTICS USING JSON
.This commit:
SQLStringFullyQualified
for arrays of UDTst.TypeMeta.Name == nil
guard toSQLString
for composite UDTsstats.(*JSONStatistic).SetHistogram
so that we get fully-qualified type annotations on histogram upper boundsNo release note because the output of
SHOW STATISTICS USING JSON
isn't documented.Fixes: #137443
Release note: None
Release justification: quality-of-life fix for regression in SHOW STATISTICS which will help with ALTER TABLE INJECT STATISTICS.