roachprod: reduce start-up lag #137916
Open
roachprod: reduce start-up lag #137916
+222
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update check takes >800ms where I am. `roachprod` is slow enough as is, so allow folks to opt out and also opt out automatically in cases where `roachprod update` doesn't work in the first place (osx). Epic: none Release note: None
|
This change is |
It takes like 400ms.
This is how I tracked down the slowness inherent in `roachprod --help`. It might come in handy again in the future; now it's gated behind the `ROACHPROD_FGPROF` env var.
Azure in particular takes a long time - sometimes well north of 1s.
tbg
requested review from
herkolategan,
vidit-bhat,
golgeek and
a team
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine (which is in Europe), this brings
time roachprod --helpfrom1.56sdown to to0.06sunder the following env vars:Under these env vars, my roachprod
aws --versionon each start (python, ~400ms)A better way (but one outside of my purview) for most of these would be to add caching for each of these and so to avoid the cost in the common case.
Azure is an exception, as the (wall-clock) profile below shows we're spending most of our time waiting for
GetTokenFromCLIWithParamsto return. It's not clear how to optimize this. (The AWS portion of the flamegraph isaws --version).Epic: none