release-24.1: sql: Check for concurrent DSC job in legacy schema changer #137887
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #137868 on behalf of @spilchen.
/cc @cockroachdb/release
Running the legacy schema changer and the declarative schema changer concurrently can cause issues due to their different approaches to updating descriptors. Normally we have checks to prevent the legacy schema changer from running in such scenarios, timing issues persisted—particularly between
ALTER VIEW .. RENAME
(legacy) andDROP VIEW
(DSC). In these cases, the view rename could delete the descriptor being processed by the drop view operation.This change addresses the timing issue by adding a check for an active DSC job at the start of the legacy schema changer job. With this fix, the issue could no longer be reproduced, whereas it was consistently reproducible before.
Epic: none
Closes: #137487
Closes: #137828
Release note (bug fix): Fixed a timing issue between
ALTER VIEW .. RENAME
andDROP VIEW
that caused repeated failures in theDROP VIEW
job.Release justification: