Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sosreport: Port to fsinfo #21059

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Oct 1, 2024

fswatch1 is being deprecated. This also gets rid of the ugly find | xargs stat shellery, as fsinfo gets us the modification time.

fsinfo also gives us an initial 'change' event, so we don't need the "initial" and "on change" handler duplication.


This by and large works fine, but there is something really concerning: Instantiating an FsInfoClient breaks an existing fswatch1 channel (which I could still understand, somehow interfering inotify's -- even though it should work). But it also breaks the

superuser.addEventListener("changed", restart);

this never gets called any more. The D-Bus notify signal itself works, but cockpit.js then messes it up. This is somehow related to the new Transport and Channel classes.

Debugging note for myself:

grep -lrw preload /usr/share/cockpit | xargs sed -i '/\bpreload\b/d'

`fswatch1` is being deprecated. This also gets rid of the ugly
`find | xargs stat` shellery, as fsinfo gets us the modification time.

fsinfo also gives us an initial 'change' event, so we don't need the "initial"
and "on change" handler duplication.
@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant