Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian Deployment Guide (Cobber v3.3.7) #188

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

sus-admin
Copy link
Contributor

No description provided.

@sus-admin
Copy link
Contributor Author

@SchoolGuy Could you review this PR for a new article when you get a chance?

@SchoolGuy
Copy link
Member

@sus-admin After a quick first look I would like you to switch in your new blog post to 3.3.7. 3.3.6 and older are containing a severe CVE and as such new material shouldn't point to older vulnerable versions.

@sus-admin
Copy link
Contributor Author

@SchoolGuy good point. I'll get that installed in my home lab and do some sanity checks and hopefully have that PR updated tonight.

By the way, did I submit correctly this time? I made a new branch on my end, but it would only let me merge into main or an older branch in the official repo.

@sus-admin sus-admin changed the title Debian Deployment Guide (Cobber v3.3.6) Debian Deployment Guide (Cobber v3.3.7) Dec 6, 2024
@sus-admin
Copy link
Contributor Author

@SchoolGuy Can you review this PR when you get the chance?

Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some more thoughts now on the content of the guide. Overall this is good in my eyes but a littlebit of polishing is needed before I will give my thumbs up.

Comment on lines 174 to 175
systemctl restart cobblerd && sleep 10
cobbler sync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it out but this shouldn't be needed. Just syncing should be fine.

Suggested change
systemctl restart cobblerd && sleep 10
cobbler sync
cobbler sync

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to make any changes to the old blog entry. The new entry should focus on 3.3.7.

Comment on lines 224 to 229
yum install -y debmirror debian-keyring
sed -i "s/@arches/#@arches/g" /etc/debmirror.conf
sed -i "s/@dists/#@dists/g" /etc/debmirror.conf
systemctl restart cobblerd && sleep 5
cobbler sync
cobbler check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: I haven't tried it but I see no need for this restart. Restarting bigger cobbler instances can take minutes which is undesired I would argue.

Suggested change
yum install -y debmirror debian-keyring
sed -i "s/@arches/#@arches/g" /etc/debmirror.conf
sed -i "s/@dists/#@dists/g" /etc/debmirror.conf
systemctl restart cobblerd && sleep 5
cobbler sync
cobbler check
yum install -y debmirror debian-keyring
sed -i "s/@arches/#@arches/g" /etc/debmirror.conf
sed -i "s/@dists/#@dists/g" /etc/debmirror.conf
cobbler sync
cobbler check

Comment on lines 306 to 347
### Apt setup
# Choose, if you want to scan additional installation media
# (default: false).
d-i apt-setup/cdrom/set-first boolean false
# You can choose to install non-free firmware.
#d-i apt-setup/non-free-firmware boolean true
# You can choose to install non-free and contrib software.
#d-i apt-setup/non-free boolean true
#d-i apt-setup/contrib boolean true
# Uncomment the following line, if you don't want to have the sources.list
# entry for a DVD/BD installation image active in the installed system
# (entries for netinst or CD images will be disabled anyway, regardless of
# this setting).
#d-i apt-setup/disable-cdrom-entries boolean true
# Uncomment this if you don't want to use a network mirror.
#d-i apt-setup/use_mirror boolean false
# Select which update services to use; define the mirrors to be used.
# Values shown below are the normal defaults.
#d-i apt-setup/services-select multiselect security, updates
#d-i apt-setup/security_host string security.debian.org

# Additional repositories, local[0-9] available
#d-i apt-setup/local0/repository string \
# http://local.server/debian stable main
#d-i apt-setup/local0/comment string local server
# Enable deb-src lines
#d-i apt-setup/local0/source boolean true
# URL to the public key of the local repository; you must provide a key or
# apt will complain about the unauthenticated repository and so the
# sources.list line will be left commented out.
#d-i apt-setup/local0/key string http://local.server/key
# or one can provide it in-line by base64 encoding the contents of the
# key file (with `base64 -w0`) and specifying it thus:
#d-i apt-setup/local0/key string base64://LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCi4uLgo=
# The content of the key file is checked to see if it appears to be ASCII-armoured.
# If so it will be saved with an ".asc" extension, otherwise it gets a '.gpg' extension.
# "keybox database" format is currently not supported. (see generators/60local in apt-setup's source)

# By default the installer requires that repositories be authenticated
# using a known gpg key. This setting can be used to disable that
# authentication. Warning: Insecure, not recommended.
#d-i debian-installer/allow_unauthenticated boolean true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like that to be a file inside this repository that is included via a relative include. More see here: https://jekyllrb.com/docs/includes/#including-files-relative-to-another-file

@sus-admin
Copy link
Contributor Author

sus-admin commented Dec 10, 2024

@SchoolGuy thanks for the feedback, I've updated my PR (I would rather just update the original post at 3.3.7 now since I've tested it already).

…oting" section - changed to file "include" instead of plaintext markdown
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants