Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metric Store Group as contributers #647

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

jbooherl
Copy link
Contributor

We have been maintaining the metric store release and believe that we meet criteria based on support interactions in #op-apps-assist-tas-metric-store

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 13, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@jbooherl jbooherl marked this pull request as draft July 13, 2023 15:07
@jbooherl jbooherl marked this pull request as ready for review July 13, 2023 15:07
Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is my understanding that this will make the working group yaml match the state of the world and that these contributors have been working on these projects for a long time. However, I am less familiar with this group and want to make sure that everyone meets the same standard for approver as described here. Please provide details about how long each person has been working on these projects and links to their contributions.

Here are several examples of people showing their work to apply as an approver

@Benjamintf1 - This PR will be adding ownership to the metric-store repos, which are currently in your area. Does this split make sense to you?

toc/working-groups/app-runtime-platform.md Outdated Show resolved Hide resolved
toc/working-groups/app-runtime-platform.md Show resolved Hide resolved
toc/working-groups/app-runtime-platform.md Show resolved Hide resolved
toc/working-groups/app-runtime-platform.md Outdated Show resolved Hide resolved
@jbooherl
Copy link
Contributor Author

It is my understanding that this will make the working group yaml match the state of the world and that these contributors have been working on these projects for a long time. However, I am less familiar with this group and want to make sure that everyone meets the same standard for approver as described here. Please provide details about how long each person has been working on these projects and links to their contributions.

I have been working as the tech lead on the project since September of 2022.
Metric Store is being maintained but there have not been a lot of sweeping changes. It is used as the backend for App Metrics which is still in use by customers and we do regular tile releases of the product.
Hovhannes is the anchor of the project. I believe his support ticket work in #op-apps-assist-tas-metric-store and possibly PRs qualify him.
Gevorg has also been supporting metric store and making changes to the metric store repo
Meri has just returned from parental leave and prior to that also committed to metric store

Here are several examples of people showing their work to apply as an approver

@Benjamintf1 - This PR will be adding ownership to the metric-store repos, which are currently in your area. Does this split make sense to you?

@beyhan beyhan added toc wg and removed toc labels Jul 18, 2023
@Benjamintf1
Copy link
Member

@ameowlia yeah, we havn't really been ever maintaining the metric-store repos.

@ameowlia ameowlia merged commit 9e8562a into cloudfoundry:main Jul 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants