fix(devbox): Downgrade bosh-cli so that make deploy-autoscaler works on macOS
#2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geigerj0
changed the title
devbox): Downgrade bosh-cli so that make deploy-autoscaler works on macOSdevbox): Downgrade bosh-cli so that make deploy-autoscaler works on macOS
geigerj0
changed the title
devbox): Downgrade bosh-cli so that make deploy-autoscaler works on macOSbosh-cli so that make deploy-autoscaler works on macOS
geigerj0
added
exclude-from-changelog
allow-acceptance-tests
silvestre
requested changes
May 22, 2024
There was a problem hiding this comment.
Please also
- Remove https://github.com/cloudfoundry/app-autoscaler-release/blob/main/renovate.json#L82-L93 as Renovate will keep the version up-to-date in
.tool-versions - Downgrade the version in
.tool-versionsas well, because https://github.com/cloudfoundry/app-autoscaler-release/blob/main/.github/workflows/asdf2devbox.yaml will try to keep the versions in sync
geigerj0
force-pushed
the
downgrade-bosh-cli-for-devbox-env
branch
from
4a93b5e
to
60d84c0
Compare
|
geigerj0
commented
May 22, 2024
silvestre
approved these changes
May 22, 2024
bonzofenix
pushed a commit
that referenced
this pull request
May 29, 2024
bonzofenix
pushed a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings #2619 also to the devbox environment.