Bump to exact Go versions during update-golang
#2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geigerj0
commented
Mar 13, 2024
geigerj0
added
the
allow-acceptance-tests
silvestre
approved these changes
Mar 13, 2024
|
This was referenced Apr 4, 2024
silvestre
pushed a commit
that referenced
this pull request
Apr 5, 2024
# Problem Go tries to download a specific toolchain version whenever the required version is not available on the system. The following PR introduced the exact Go toolchain version pinning #2757. Requiring an exact Go toolchain version can make the acceptance tests execution fail in an environment that has no connectivity to the public internet. Here is a sample failure from an execution in China which tries to download a required toolchain version: ``` download go1.21.4: golang.org/[email protected]: Get "https://proxy.golang.org/golang.org/toolchain/@v/v0.0.1-go1.21.4.linux-amd64.zip": dial tcp 172.217.163.49:443: i/o timeout ``` # Solution Compile test suites and ginkgo CLI for * `linux` (`amd64`, `arm64`) * `darwin` (`amd64`, `arm64`) Acceptance test executions with no public internet access can make use of these binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As of Go
1.21, versions specified ingo.modfiles are treated not as a guideline but as a strict rule. Also,go 1.21is automatically being mapped to1.21.0.The following example basically says that Go
1.21.0is requiredapp-autoscaler-release/src/autoscaler/go.mod
Line 3 in 13755c9
Which causes problems because the "
1.21->1.21.0mapping" doesn't work forgo.workfilesapp-autoscaler-release/go.work
Line 1 in 13755c9
Example of a failing CI build:
go.work file requires go >= 1.21.0, but go.work lists go 1.21.Solution
go.workduring the bumping process.Somewhat related changes
go.mod- andgo.workfiles to the currently used version1.21.3Create Bosh Releasepipeline future proof for Go>=1.22.0, see Bump to exact Go versions duringupdate-golang#2757 (comment)