Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground,quick-editor): send raw request method through custom header instead of request method #7630

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edmundhung
Copy link
Member

Fixes DEVX-1449.

This PR fixes an issue in which the preview worker does not receive an raw OPTIONS request on both Quick Editor or Workers Playground.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: de409d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@edmundhung edmundhung added preview:workers-playground Trigger a workers playground preview deploy preview:quick-edit Trigger a quick edit preview deploy labels Dec 24, 2024
Copy link
Contributor

github-actions bot commented Dec 24, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-wrangler-7630

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7630/npm-package-wrangler-7630

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-wrangler-7630 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-workers-bindings-extension-7630 -O ./cloudflare-workers-bindings-extension.0.0.0-v17312573e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v17312573e.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-create-cloudflare-7630 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-kv-asset-handler-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-miniflare-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-pages-shared-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-unenv-preset-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-vitest-pool-workers-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-workers-editor-shared-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-workers-shared-7630
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12483242567/npm-package-cloudflare-workflows-shared-7630

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview:quick-edit Trigger a quick edit preview deploy preview:workers-playground Trigger a workers playground preview deploy
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant