Key the Early Hints off of the asset key rather than request path #7564
Conversation
🦋 Changeset detectedLatest commit: b146e8d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ) { | ||
| const preEarlyHintsHeaders = new Headers(headers); | ||
|
|
||
| // "Early Hints cache entries are keyed by request URI and ignore query strings." | ||
| // https://developers.cloudflare.com/cache/about/early-hints/ | ||
| const earlyHintsCacheKey = `${protocol}//${host}${pathname}`; | ||
| const earlyHintsCacheKey = `${protocol}//${host}/${eTag}`; |
There was a problem hiding this comment.
I could do something like we did for asset preservation v2 where we simultaneously checked the old and new formats to prevent a flood of new cache misses as we roll this out.
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-wrangler-7564You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7564/npm-package-wrangler-7564Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-wrangler-7564 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-create-cloudflare-7564 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-cloudflare-kv-asset-handler-7564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-miniflare-7564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-cloudflare-pages-shared-7564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-cloudflare-vitest-pool-workers-7564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-cloudflare-workers-editor-shared-7564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-cloudflare-workers-shared-7564npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354867181/npm-package-cloudflare-workflows-shared-7564Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Keys the Early Hints cache entries off of the asset key rather than the request path.
I could do something like we did for asset preservation v2 where we simultaneously checked the old and new formats to prevent a flood of new cache misses as we roll this out.