Skip parsing Early Hints for known empty results #7561
+183
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 356e483 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GregBrimble
commented
Dec 16, 2024
| test.todo( | ||
| "early hints should temporarily cache failures to parse links", | ||
| async () => { | ||
| // I couldn't figure out a way to make HTMLRewriter error out |
There was a problem hiding this comment.
I tried:
- a PNG with
image/png(but we have a check earlier for the content type) - a PNG with
text/html(but HTMLRewriter just skipped over it fine) - malformed HTML (but HTMLRewriter just skipped over it fine)
GregBrimble
force-pushed
the
early-hints-store-empty-links
branch
from
e533b97 to
356e483
Compare
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-wrangler-7561You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7561/npm-package-wrangler-7561Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-wrangler-7561 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-create-cloudflare-7561 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-cloudflare-kv-asset-handler-7561npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-miniflare-7561npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-cloudflare-pages-shared-7561npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-cloudflare-vitest-pool-workers-7561npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-cloudflare-workers-editor-shared-7561npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-cloudflare-workers-shared-7561npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12354029659/npm-package-cloudflare-workflows-shared-7561Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
CarmenPopoviciu
force-pushed
the
check-if-none-match-before-fulfilling-preservation-cache
branch
from
e0e7703 to
82dcab8
Compare
Base automatically changed from
check-if-none-match-before-fulfilling-preservation-cache
to
main
December 19, 2024 14:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store an empty result when Early Hints parsing returns nothing or errors. Previously, we weren't storing anything which resulted in Early Hints being parsed on every request.