Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQC-352 SQC-353 Create cert upload command for client side mtls certificate/CA chain certificates #7466

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ltadrian
Copy link

@Ltadrian Ltadrian commented Dec 5, 2024

Create cert upload command for client side mtls certificate/CA chain certificates

Fixes #[insert GH or internal issue link(s)].

  • Allows the capability to upload custom CA certificates and client mTLS certificates. This is a lot similar to mtls-certificate command but our goal was to avoid confusion with workers support. This custom CA certificates upload is not a supported binding for workers. It will be available as a Hyperdrive binding very soon.

Internal JIRA
SQC-352
SQC-353


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@Ltadrian Ltadrian requested a review from a team as a code owner December 5, 2024 23:25
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 03af501

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/wrangler/src/cert/cli.ts Outdated Show resolved Hide resolved
import { type MTlsCertificateResponse } from "../api/mtls-certificate";

describe("wrangler", () => {
const accountId = "1a2b3c4d";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this if we're using mockAccountId()?

@lrapoport-cf
Copy link
Contributor

hi @Ltadrian :) we recently introduced a new createCommand utility to be used when new commands are being added. can you please review https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/CONTRIBUTING.md and update this PR accordingly? thank you!

@Ltadrian Ltadrian force-pushed the ltadrian/cert-upload-mtls branch 3 times, most recently from bbc821f to 15327ba Compare December 10, 2024 18:46
@Ltadrian Ltadrian force-pushed the ltadrian/cert-upload-mtls branch from 15327ba to 03af501 Compare December 10, 2024 18:58
@Ltadrian
Copy link
Author

hi @Ltadrian :) we recently introduced a new createCommand utility to be used when new commands are being added. can you please review https://github.com/cloudflare/workers-sdk/blob/main/packages/wrangler/CONTRIBUTING.md and update this PR accordingly? thank you!

this has been updated now, thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants