Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Images binding #7424

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

ns476
Copy link
Contributor

@ns476 ns476 commented Dec 3, 2024

Fixes IMAGES-1400, IMAGES-1401, IMAGES-1402

Adds support for the Images binding, with two kinds of preview:

  • Remote: hits a remote endpoint that exposes the same HTTP interface used in production
  • Local: uses a local fake that only supports rotating, resizing and transcoding, intended mainly for use in tests.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@ns476 ns476 requested review from a team as code owners December 3, 2024 15:09
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 1d9182c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 3, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-wrangler-7424

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7424/npm-package-wrangler-7424

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-wrangler-7424 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-create-cloudflare-7424 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-cloudflare-kv-asset-handler-7424
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-miniflare-7424
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-cloudflare-pages-shared-7424
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-cloudflare-vitest-pool-workers-7424
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-cloudflare-workers-editor-shared-7424
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-cloudflare-workers-shared-7424
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12142527549/npm-package-cloudflare-workflows-shared-7424

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the blocked Blocked on other work label Dec 5, 2024
@penalosa penalosa marked this pull request as draft December 9, 2024 10:18
@penalosa
Copy link
Contributor

penalosa commented Dec 9, 2024

@ns476 It doesn't look like this is ready for review yet, so I've converted this to draft for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants