Add compatibility date for Pyodide 0.26.4 #3268
Conversation
hoodmane
force-pushed
the
hoodmane/python-workers-v2-compat-date
branch
from
45c5971 to
76beac7
Compare
| @@ -673,4 +673,11 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef { | |||
| tailWorkerUserSpans @69 :Bool | |||
| $compatEnableFlag("tail_worker_user_spans") | |||
| $experimental; | |||
|
|
|||
| pythonWorkersV2 @70 :Bool | |||
There was a problem hiding this comment.
Again the V2 looks wrong to me, I don't know if that's the way we should go down.
We'll eventually have v2, v3, v4, v5 ... but that's not very descriptive of what they are and why the user should use one or the other.
There was a problem hiding this comment.
I was thinking that we'll just add a bunch of $impliedByAfterDate's and the user passes python_workers and a date.
There was a problem hiding this comment.
In any case, I think it's okay to change the name as long as it's marked experimental. I also don't think "pyodide v0.26.4" means that much to the end users. Calendar versioning would be reasonable like pythonWorkers_2024_12.
There was a problem hiding this comment.
Yeah calendar versioning seems better than pyodide versioning, I agree the pyodide version doesn't tell the user much
There was a problem hiding this comment.
My only reluctance is that I don't see any compat flags with underscores in their names. But camel case doesn't really work for dates...
There was a problem hiding this comment.
I think I see what you mean.
Alright so let's document this above the python_workers flag.
And let's rename the flag to pythonWorkers20241218.
And we'll document that this
- pyodide versions are updated by pythonWorkersYYYYMMDD flags
- These flags will remain experimental forever
- Users update pyodide version by updating their compat date which will enable the flag via the impliedByAfterDate
- Anything else?
There was a problem hiding this comment.
Does experimental just stop the user from setting the flag directly with the enable flag and still allow it to be set by implies_by_after_date?
There was a problem hiding this comment.
Anyways, if that doesn't work we can always remove both experimental and the enable_flag once we add an impliedByAfterDate.
There was a problem hiding this comment.
Does experimental just stop the user from setting the flag directly
yes.
still allow it to be set by implies_by_after_date?
I don't know, but if not then we need another approach here.
There was a problem hiding this comment.
doesn't work we can always remove both
experimental
Yeah that would work, add that to the documentation above
hoodmane
force-pushed
the
hoodmane/python-workers-v2-compat-date
branch
4 times, most recently
from
6682892 to
521fe8c
Compare
hoodmane
force-pushed
the
hoodmane/python-workers-v2-compat-date
branch
from
521fe8c to
379fb1e
Compare
No description provided.